From b7cc51f1af0700c637ae442c0a0cd2484bb9983d Mon Sep 17 00:00:00 2001 From: jebbs Date: Tue, 11 Oct 2022 10:51:00 +0800 Subject: [PATCH] add FIXME --- outbound/balancer.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/outbound/balancer.go b/outbound/balancer.go index 2e8bdf8a..19ee42d6 100644 --- a/outbound/balancer.go +++ b/outbound/balancer.go @@ -50,6 +50,12 @@ func NewBalancer( } // Network implements adapter.Outbound +// +// FIXME: logic issue: +// picked node is very likely to be different between first "Network() assetion" +// then "NewConnection()", maybe we need to keep the picked node in the context? +// that requests to change the Network() signature of the interface of +// adapter.Outbound func (s *Balancer) Network() []string { picked := s.pick() if picked == nil {